TEST-33: Mainnet governance config validation tests#432
Merged
mtabasco merged 3 commits intossv-stakingfrom Feb 25, 2026
Merged
TEST-33: Mainnet governance config validation tests#432mtabasco merged 3 commits intossv-stakingfrom
mtabasco merged 3 commits intossv-stakingfrom
Conversation
Add comprehensive test suite validating SSV Network behavior with exact mainnet deployment parameters from hoodi-upgrade.config.json. Covers 8 test scenarios across packability, liquidation threshold, operator fee boundaries, cluster burn rate, cooldown duration, quorum, liquidation collateral, and long-running cluster overflow checks (21 test cases). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Gas Usage ReportCommit: All operations are within gas limits. |
liorrutenberg
requested review from
Copilot,
mtabasco,
venimir-ssv and
yurii-ssv
and removed request for
mtabasco and
venimir-ssv
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive test suite that validates SSV Network system behavior using exact mainnet deployment parameters from deployments/hoodi-upgrade.config.json. The test file covers 8 critical scenarios with 21 individual test cases validating packability, liquidation mechanics, operator fee boundaries, burn rates, cooldown periods, quorum voting, and long-running cluster scenarios.
Changes:
- Added
test/unit/mainnet-config-validation.test.tswith 730 lines of comprehensive tests covering all mainnet governance parameters and edge cases - Updated
package-lock.jsonwith dependency metadata changes (peer flags)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| test/unit/mainnet-config-validation.test.ts | New comprehensive test suite validating 8 scenarios: packability of fee values, liquidation threshold calculations, operator fee boundaries, cluster burn rates, cooldown duration mechanics, quorum voting with 4 oracles at 75%, liquidation collateral thresholds, and 1-year cluster simulations |
| package-lock.json | Automatic dependency metadata updates (peer flags) from npm |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* adjust defaultOperatorEthFee mainnet value * cleanup comments * add more cases * avoid hardcoding where possible
yurii-ssv
approved these changes
Feb 19, 2026
venimir-ssv
approved these changes
Feb 19, 2026
* feat: introduce params json * feat: add validation tests for the params ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/unit/mainnet-config-validation.test.ts) validating SSV Network system behavior with exact mainnet deployment parameters fromdeployments/hoodi-upgrade.config.jsonminimumLiquidationCollateraldominates; tests exact boundary (strict less-than)declareOperatorFeeblock.timestampseconds; cannot claim at half-cooldown, can claim after full cooldownminimumLiquidationCollateralEthTest plan
npx hardhat test test/unit/mainnet-config-validation.test.ts)🤖 Generated with Claude Code